[Refactor] Improve file download functionality #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaMor
force-pushed
the
tinamor/refactor-download-uri
branch
from
67cec45 to
7956f90
Compare
billywr
reviewed
Sep 3, 2024
billywr
reviewed
Sep 3, 2024
billywr
previously approved these changes
Sep 3, 2024
- Add support for non-AMD64 architectures
- add support for containernetworking/plugins (Instal-WinCNIPlugin)
- Enhance robustness against versioning changes in release assets: e.g. "v1.0.0" and "1.0.0" are now considered the same version
TinaMor
force-pushed
the
tinamor/refactor-download-uri
branch
from
7956f90 to
547246a
Compare
billywr
approved these changes
Oct 1, 2024
iankingori
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Github issue/discussion(s)
Issue #8: Support for Multiple OS Architectures
Expanded the installation process to support architectures other than AMD64, including ARM64 and x86.
Added logic to dynamically select the appropriate architecture when downloading container tools, making the installation process more versatile and inclusive.
Issue #18: Allow for CNI 1.0.0
Added explicit support for installing CNI version 1.0.0. Ensured that the installation process can correctly identify and download the appropriate version of CNI, even when tag formats vary.
Fix Release Tags Parsing for Windows Container Networking
Enhanced the robustness of the versioning system for release assets, making it resilient to changes in version formats. This prevents failures during installation when new versions of tools are released with different tagging conventions.
Corrected the inconsistency in release tags between e.g. v1.0.0 and 1.0.0. Both are now considered the same version, ensuring that the correct assets are downloaded regardless of the tag format.
Shifted from parsing URLs to using GitHub's API /releases endpoint to reliably obtain the download URLs for assets. This change improves the accuracy and reliability of the download process, ensuring that the correct files are fetched regardless of tag inconsistencies.
...is the same as:
Checklist
As part of our commitment to engineering excellence, before submitting this PR, please make sure:
In addition, after this PR has been reviewed, please agree to: