Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users/oakeredolu/newpipservice #683

Merged
merged 15 commits into from
Aug 1, 2023
Merged

Conversation

Omotola
Copy link
Contributor

@Omotola Omotola commented Jul 31, 2023

Added a new python resolver for the new simple pypi client. The main changes from the old python resolver is that this python resolver handles converting the project we get from simple pypi into internal contract ( PythonProjectRelease), and it extracts and resolves dependencies from the python wheel.

Also moved PythonResolverState to its own file and made it public so its accessible from the new resolver.

#672

@Omotola Omotola requested a review from a team as a code owner July 31, 2023 08:40
@Omotola Omotola requested a review from cobya July 31, 2023 08:40
@melotic
Copy link
Member

melotic commented Jul 31, 2023

It's hard to review this since it also includes changes from #672

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@Omotola Omotola enabled auto-merge (squash) August 1, 2023 21:06
@Omotola Omotola merged commit 838766b into main Aug 1, 2023
@Omotola Omotola deleted the users/oakeredolu/newpipservice branch August 1, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants