Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize another Docker telemetry event #1164

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

grvillic
Copy link
Contributor

@grvillic grvillic commented Jun 7, 2024

Context

There is another Docker event logging the docker image response which can include environment variables. We need to sanitize them to prevent logging creds pointing to feeds.

@grvillic grvillic requested a review from a team as a code owner June 7, 2024 03:49
@grvillic grvillic requested a review from annaowens June 7, 2024 03:49
@grvillic grvillic enabled auto-merge (squash) June 7, 2024 03:49
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.3%. Comparing base (341b036) to head (e8a0142).

Files Patch % Lines
...crosoft.ComponentDetection.Common/DockerService.cs 85.7% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1164   +/-   ##
=====================================
  Coverage   76.3%   76.3%           
=====================================
  Files        256     256           
  Lines      11329   11333    +4     
  Branches    1138    1138           
=====================================
+ Hits        8649    8653    +4     
  Misses      2348    2348           
  Partials     332     332           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grvillic grvillic merged commit 2b5b657 into main Jun 7, 2024
24 of 25 checks passed
@grvillic grvillic deleted the users/grvillic/SanitizeEnvVar branch June 7, 2024 04:02
Copy link

github-actions bot commented Jun 7, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants