-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluating invalid maven scope as "Compile" #1033
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1033 +/- ##
=====================================
Coverage 75.4% 75.4%
=====================================
Files 236 236
Lines 10412 10417 +5
Branches 1041 1042 +1
=====================================
+ Hits 7855 7859 +4
Misses 2267 2267
- Partials 290 291 +1 ☔ View full report in Codecov by Sentry. |
test/Microsoft.ComponentDetection.Detectors.Tests/MavenParsingUtilitiesTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to bump the detector versions that use this parsing utility since we are generating a different dependency graph than before.
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
ee9f2ec
to
3d37f1e
Compare
Summary:
Currently maven detector is failing for invalid
<scope>
in maven dependency file. However, these dependencies are valid as per maven cli and evaluated as "Compile". Component Detector matches the maven's behavior to evaluate these "invalid" scope as "Compile"#858
Testing: