Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glharper/audio input reattach fix #402

Merged
merged 5 commits into from
Jul 13, 2021
Merged

Conversation

glharper
Copy link
Member

FF threw error when referencing srcFrame.length if srcFrame is null/undefined.

@glharper glharper requested a review from BrianMouncer July 13, 2021 20:29
Copy link
Contributor

@BrianMouncer BrianMouncer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good. only pet peeve is having multiple returns from a functions, but that's not entirely your fault... :-)

@glharper glharper merged commit 7b5e5ca into master Jul 13, 2021
BrianMouncer pushed a commit that referenced this pull request Jul 13, 2021
* Fix push stream not being reconnected to with start-stop-start continuous recognition, add test

* change timeout for added test

* Fix error when down sampling with audioWorkletNode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants