Add proxy support for nodeJS. #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the proxy package depends on node features, when the webpack is built this change will skip building it in and will replace any use of it with an exception. Since the use is conditional to using a WebSocket library that also only works in node, this should be safe.
fmegen
reviewed
Mar 13, 2019
| @@ -74,7 +76,7 @@ | |||
| "usePathForSuiteName": "true" | |||
| }, | |||
| "dependencies": { | |||
| "@types/ws": "^6.0.1", | |||
| "https-proxy-agent": "^2.2.1", | |||
There was a problem hiding this comment.
"https-proxy-agent": "^2.2.1" [](start = 2, length = 31)
do we need a legal review and add this to our open-source dependencies?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the proxy package depends on node features, when the webpack is built this change will skip building it in and will replace any use of it with an exception. Since the use is conditional to using a WebSocket library that also only works in node, this should be safe.