Fix vm2 vulnerability: remove superagent-proxy dependency #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucen-ms
reviewed
Aug 7, 2023
src/utils/request-manager.ts
Outdated
| @@ -2,8 +2,8 @@ import superagent = require("superagent"); | |||
| import { CodePushUnauthorizedError } from "../script/code-push-error" | |||
| import { CodePushError, Headers } from "../script/types"; | |||
|
|
|||
| var superproxy = require("superagent-proxy"); | |||
| superproxy(superagent); | |||
| import superagent_setup from "./superagent-proxy.js"; | |||
There was a problem hiding this comment.
Why don't we directly use proxy-agent here?
DmitriyKirakosyan
force-pushed
the
fix/vm2
branch
from
c873ba9 to
7f2fbfb
Compare
lucen-ms
approved these changes
Aug 16, 2023
This was referenced Aug 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove the
superagent-proxypackage, as it's not maintained anymore and depends on the vulnerable vm2 package.agent-proxyis used directly withsuperagent'sRequestobject now.AB#101666