-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumping version #227
Bumping version #227
Conversation
Bumping the minor version to release PhoneGap support via the release-cordova command as well as some bug fixes.
Hi @rub8n, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "code-push-cli", | |||
"version": "1.10.0-beta", | |||
"version": "1.10.1-beta", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this 1.11.0-beta
since we're adding the new proxy feature, and also, don't forget to update the code-push
dependency to 1.9.0-beta
to pull in the updates to the SDK needed for the proxy feature.
@lostintangent sounds good. Modified the versions and updated the docs to call out the new functionality. |
LGTM |
@@ -245,7 +260,7 @@ Once your app has been configured to query for updates against the CodePush serv | |||
|
|||
2. [React Native](#releasing-updates-react-native) - Performs the same functionality as the general release command, but also handles the task of generating the updated app contents for you (JS bundle and assets), instead of requiring you to run both `react-native bundle` and then `code-push release`. | |||
|
|||
3. [Cordova](#releasing-updates-cordova) - Performs the same functionality as the general release command, but also handles the task of preparing the app update for you, instead of requiring you to run both `cordova prepare` and then `code-push release`. | |||
3. [Cordova](#releasing-updates-cordova) - Performs the same functionality as the general release command, but also handles the task of preparing the app update for you, instead of requiring you to run both `cordova prepare` (or `phonegap build` for PhoneGap instances) and then `code-push release`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be phonegap prepare
, and we can probably remove the for PhoneGap instances
section.
LGTM! |
Thanks guys! |
Hi @rub8n, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
Bumping the minor version to release PhoneGap support via the release-cordova command as well as some bug fixes.