Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping version #227

Merged
merged 4 commits into from
May 18, 2016
Merged

Bumping version #227

merged 4 commits into from
May 18, 2016

Conversation

rub8n
Copy link
Contributor

@rub8n rub8n commented May 17, 2016

Bumping the minor version to release PhoneGap support via the release-cordova command as well as some bug fixes.

Bumping the minor version to release PhoneGap support via the  release-cordova  command as well as some bug fixes.
@msftclas
Copy link

Hi @rub8n, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Ruben Rios). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@@ -1,6 +1,6 @@
{
"name": "code-push-cli",
"version": "1.10.0-beta",
"version": "1.10.1-beta",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this 1.11.0-beta since we're adding the new proxy feature, and also, don't forget to update the code-push dependency to 1.9.0-beta to pull in the updates to the SDK needed for the proxy feature.

@rub8n
Copy link
Contributor Author

rub8n commented May 18, 2016

@lostintangent sounds good.

Modified the versions and updated the docs to call out the new functionality.

@shishirx34
Copy link
Contributor

LGTM

@@ -245,7 +260,7 @@ Once your app has been configured to query for updates against the CodePush serv

2. [React Native](#releasing-updates-react-native) - Performs the same functionality as the general release command, but also handles the task of generating the updated app contents for you (JS bundle and assets), instead of requiring you to run both `react-native bundle` and then `code-push release`.

3. [Cordova](#releasing-updates-cordova) - Performs the same functionality as the general release command, but also handles the task of preparing the app update for you, instead of requiring you to run both `cordova prepare` and then `code-push release`.
3. [Cordova](#releasing-updates-cordova) - Performs the same functionality as the general release command, but also handles the task of preparing the app update for you, instead of requiring you to run both `cordova prepare` (or `phonegap build` for PhoneGap instances) and then `code-push release`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be phonegap prepare, and we can probably remove the for PhoneGap instances section.

@lostintangent
Copy link
Member

LGTM!

@rub8n
Copy link
Contributor Author

rub8n commented May 18, 2016

Thanks guys!

@rub8n rub8n closed this May 18, 2016
@rub8n rub8n reopened this May 18, 2016
@msftclas
Copy link

Hi @rub8n, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Ruben Rios). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@rub8n rub8n merged commit c53c196 into master May 18, 2016
@buptkang buptkang deleted the version_bump branch September 7, 2017 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants