Remove old APIs to help with removing older module dependencies. #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavanNeerudu
requested review from
nwoodmsft,
zawachte and
pradipd
as code owners
zawachte
approved these changes
Mar 8, 2024
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes old api versions v1alpha3 and v1alpha4 from the repository. These versions are old and are no longer used in any deployment.
When the cluster-api module is bumped in mgmtappl, the current CAPH code v1alpha3 and v1alpha4 api's import older api's of cluster-api which are removed in the newer versions. This is causing some problems with modules upgrade in other upstream repositories. Also, when the cluster-api module is updated to higher version, CAPH is also going to hit similar problems.