Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-<< looks off with font-weight set to 300 #355

Closed
rbusquet opened this issue Aug 31, 2020 · 1 comment · Fixed by #352
Closed

-<< looks off with font-weight set to 300 #355

rbusquet opened this issue Aug 31, 2020 · 1 comment · Fixed by #352

Comments

@rbusquet
Copy link

rbusquet commented Aug 31, 2020 •
edited
Loading

Environment

Cascadia Code version number:  2008.25
Application (with version) used to display text: PyCharm 2020.2.1, Chrome 85.0.4183.83 
OS platform and version: macOS catalina
Screen resolution (i.e. 220dpi): 192dpi (I think)

Any other software? No

Steps to reproduce

In chrome, change CSS of an element to use: -<<

{
    font-family: 'Cascadia Code';
    font-weight: 300,
}

Expected behavior

Expected the same for >>- but reversed
image

And this is how it looks like with normal fontweight:
image

Actual behavior

image

PyCharm using this font weight by default and I can't find a setting to change it
@aaronbell
Copy link
Collaborator

Thanks! Will fix that :)

@aaronbell aaronbell mentioned this issue Sep 1, 2020
Merged
3 tasks
DHowett pushed a commit that referenced this issue Sep 14, 2020
@aaronbell
Add OVERLAP flag to simple/compound glyphs, fix interpl. error (#352)
f9145d5 
This commit modifies the build script to add "OVERLAP_SIMPLE" to normal
glyphs and "OVERLAP_COMPOUND" to component glyphs. 

Under FreeType, "overlapping contours can produce pixels with inflated
coverage because FreeType normally integrates the coverage. To mitigate
the artefacts, oversampling is necessary (increase resolution 4x4 and
average the results)" ([mailinglist quote]). FreeType relies on the
"OVERLAP_SIMPLE" and "OVERLAP_COMPOUND" flags to be set to know when
this oversampling should take place. 

At current, Cascadia does not contain either of these two flags. This
fix will add one or the other to every glyph in Cascadia (depending on
type of glyph), thus resolving the issue. Once the ufo2ft library adds
functionality to address this issue, the build script modification can
be removed. 

The addition of these flags has no impact on the behavior of the font in
Mac or Windows environments. 

Closes #350
Closes #355 - switches contour order to resolve interpolation error at wght 300

[mailinglist quote]: https://savannah.nongnu.org/bugs/index.php?59026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add OVERLAP flag to simple/compound glyphs, fix interpl. error aaronbell/cascadia-code
2 participants
@rbusquet @aaronbell