Skip to content

Commit

Permalink
Cascadia Code Upright bugfixes (#482)
Browse files Browse the repository at this point in the history
A large set of bug fixes identified while working on the Italic, but solving
Github reported issues. 

## PR Checklist
- [x] Closes #422 - Bitcoin added
- [x] Closes #427 - FFFD glyph added
- [x] Closes #418 - top bar corrected
- [x] Closes #433 - hinting corrected to ensure alignment
- [x] Closes #435 - adds consistent ligature form for `=>>` `<<=` `=<<` and
  `>>=` (the infinite arrows still work with addition of more equals)
- [x] Closes #443 - ligature now ignores (*) scenario
- [x] Closes #454 - adds ignore to prevent equal_equal ligature from showing up
- [x] Closes #467 - Not specifically sure of the problem here, but suspect that
  it will be fixed with this - update.
- [x] Closes #477 - fixed
- [x] Closes #478 - fixed
- [x] Closes #479 - fixed
- [x] Closes #480 - fixed
- [x] Closes #481 - JetBrains enumerates fonts weird. I've modified the
  internal naming so that it will register Cascadia Code correctly. Also
  aligned postscript naming with Google's recommendation, so will show up as
  "Regular" instead of "Roman". Still works in Word!


Other Cascadia Code fixes:
- General improvement of weight balancing
- Weight of lowercase rounds reduced in the Bold weight in Cascadia Code.
- Weight of Capital stems increased in Extralight weight in Cascadia Code. 
- Tweaked weight of ogonek in ExtraLight.
- Added a localized form for ij and IJ should a user chose to use those
  codepoints and want an accented version.
- Split fraction bar at heavier weights to improve clarity of fractions.
- Adjusted standard box drawing characters to align with GDI metrics, and added
  a complete set of DWrite-specific ones that align with sTypo (using `rclt`).
- Ironed out some tiny inconsistencies in the <$ $> <$> ligatures which I'm
  sure no one will ever notice. 
- Fixed centering of braces and some hyphens.
- Fixed inconsistency between semicolon/colon and period weight in bold. Also
  fixed slight differences in hyphen-like glyphs in bold. You're as surprised
  as I am. 
- Increased weight of underscore in bold.
- Adjusted weighting of Ɫ.
- Changed design of commaaccent, commaaccentmod commaturnedabove and commaabove
  to be more distinguishable (following design of quotes).
- Increased height of βδθλ to align with the ascender height. They were too low
  before. 
- Fixed descents of various greek lowercase glyphs that were inconsistent. 
- Modified ξ weighting. 
- Felt ligated, might edit later.
- Tweaked ªºⁿʷʸᶿᶻ⁰¹²³⁴⁵⁶⁷⁸⁹ in imperceptable ways. 
- Corrected some additional interpolation bugs

I do enjoy giving Dustin presents.
  • Loading branch information
aaronbell authored May 28, 2021
1 parent 253234d commit b0a6b2a
Show file tree
Hide file tree
Showing 11,681 changed files with 220,035 additions and 42,193 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
5 changes: 2 additions & 3 deletions build.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
OUTPUT_STATIC_WOFF2_DIR = OUTPUT_WOFF2_DIR / "static"
INPUT_DIR = Path("sources")
VTT_DATA_FILE = INPUT_DIR / "vtt_data" / "CascadiaCode_VTT.ttf"
ITALIC_VTT_DATA_FILE = INPUT_DIR / "vtt_data" / "CascadiaCode-Italic_VTT.ttf"
ITALIC_VTT_DATA_FILE = INPUT_DIR / "vtt_data" / "CascadiaCodeItalic_VTT.ttf"
FEATURES_DIR = INPUT_DIR / "features"
NERDFONTS_DIR = INPUT_DIR / "nerdfonts"

Expand Down Expand Up @@ -274,8 +274,7 @@ def compile_variable_and_save(
varFont["head"].flags = 0x000b

if "Regular" in styleName:
varFont["name"].setName(familyName.replace(" ","")+"-Roman", 6, 3, 1, 1033)
varFont["name"].setName("Roman", 17, 3, 1, 1033)
varFont["name"].setName(familyName.replace(" Regular",""), 4, 3, 1, 1033)
varFont["name"].setName(familyName.replace(" ","")+"Roman", 25, 3, 1, 1033)

print(f"[{familyName} {styleName}] Saving")
Expand Down
557 changes: 545 additions & 12 deletions sources/CascadiaCode-Bold.ufo/features.fea

Large diffs are not rendered by default.

20 changes: 8 additions & 12 deletions sources/CascadiaCode-Bold.ufo/fontinfo.plist
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@
<array>
<dict>
<key>angle</key>
<integer>0</integer>
<integer>180</integer>
<key>name</key>
<string> [locked]</string>
<key>x</key>
<integer>1117</integer>
<integer>1107</integer>
<key>y</key>
<integer>333</integer>
</dict>
Expand Down Expand Up @@ -66,7 +66,7 @@
</dict>
<dict>
<key>angle</key>
<integer>90</integer>
<integer>270</integer>
<key>name</key>
<string> [locked]</string>
<key>x</key>
Expand All @@ -80,7 +80,7 @@
<key>name</key>
<string> [locked]</string>
<key>x</key>
<integer>2160</integer>
<integer>2194</integer>
<key>y</key>
<integer>332</integer>
</dict>
Expand All @@ -90,13 +90,13 @@
<key>name</key>
<string> [locked]</string>
<key>x</key>
<integer>2120</integer>
<integer>2154</integer>
<key>y</key>
<integer>342</integer>
</dict>
<dict>
<key>angle</key>
<integer>90</integer>
<integer>270</integer>
<key>name</key>
<string> [locked]</string>
<key>x</key>
Expand Down Expand Up @@ -174,11 +174,11 @@
</dict>
<dict>
<key>angle</key>
<integer>0</integer>
<integer>90</integer>
<key>name</key>
<string> [locked]</string>
<key>x</key>
<integer>1117</integer>
<integer>1047</integer>
<key>y</key>
<integer>843</integer>
</dict>
Expand Down Expand Up @@ -280,10 +280,6 @@ THE FONT SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<integer>-100</integer>
<key>postscriptUnderlineThickness</key>
<integer>100</integer>
<key>styleMapFamilyName</key>
<string>Cascadia Code</string>
<key>styleMapStyleName</key>
<string>bold</string>
<key>styleName</key>
<string>Bold</string>
<key>trademark</key>
Expand Down
20 changes: 20 additions & 0 deletions sources/CascadiaCode-Bold.ufo/glyphs.-10/contents.plist
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<?xml version='1.0' encoding='UTF-8'?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>he-hb</key>
<string>he-hb.glif</string>
<key>het-hb</key>
<string>het-hb.glif</string>
<key>kaf-hb</key>
<string>kaf-hb.glif</string>
<key>lamed-hb</key>
<string>lamed-hb.glif</string>
<key>shin-hb</key>
<string>shin-hb.glif</string>
<key>tav-hb</key>
<string>tav-hb.glif</string>
<key>yod-hb</key>
<string>yod-hb.glif</string>
</dict>
</plist>
43 changes: 43 additions & 0 deletions sources/CascadiaCode-Bold.ufo/glyphs.-10/he-hb.glif
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<?xml version='1.0' encoding='UTF-8'?>
<glyph name="he-hb" format="2">
<advance width="1119"/>
<unicode hex="05D4"/>
<outline>
<contour>
<point x="379" y="0" type="line"/>
<point x="379" y="683" type="line"/>
<point x="146" y="683" type="line"/>
<point x="146" y="0" type="line"/>
</contour>
<contour>
<point x="208" y="1233" type="curve"/>
<point x="120" y="988" type="line"/>
<point x="167" y="960"/>
<point x="269" y="929"/>
<point x="366" y="929" type="curve" smooth="yes"/>
<point x="617" y="929" type="line"/>
<point x="717" y="926"/>
<point x="766" y="873"/>
<point x="766" y="753" type="curve"/>
<point x="999" y="870" type="line"/>
<point x="999" y="1077"/>
<point x="888" y="1200"/>
<point x="704" y="1200" type="curve"/>
<point x="392" y="1200" type="line" smooth="yes"/>
<point x="320" y="1200"/>
<point x="248" y="1217"/>
</contour>
<contour>
<point x="999" y="0" type="line"/>
<point x="999" y="877" type="line"/>
<point x="766" y="754" type="line"/>
<point x="766" y="0" type="line"/>
</contour>
</outline>
<lib>
<dict>
<key>public.markColor</key>
<string>0.98,0.36,0.67,1</string>
</dict>
</lib>
</glyph>
54 changes: 54 additions & 0 deletions sources/CascadiaCode-Bold.ufo/glyphs.-10/het-hb.glif
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
<?xml version='1.0' encoding='UTF-8'?>
<glyph name="het-hb" format="2">
<advance width="1119"/>
<unicode hex="05D7"/>
<outline>
<contour>
<point x="379" y="646" type="line"/>
<point x="379" y="755"/>
<point x="383" y="929"/>
<point x="541" y="929" type="curve"/>
<point x="298" y="994" type="line"/>
<point x="298" y="922" type="line"/>
<point x="208" y="892"/>
<point x="146" y="796"/>
<point x="146" y="646" type="curve"/>
</contour>
<contour>
<point x="379" y="0" type="line"/>
<point x="379" y="665" type="line"/>
<point x="146" y="665" type="line"/>
<point x="146" y="0" type="line"/>
</contour>
<contour>
<point x="208" y="1233" type="curve"/>
<point x="120" y="988" type="line"/>
<point x="167" y="960"/>
<point x="269" y="929"/>
<point x="316" y="929" type="curve"/>
<point x="617" y="929" type="line"/>
<point x="717" y="926"/>
<point x="766" y="873"/>
<point x="766" y="753" type="curve"/>
<point x="999" y="870" type="line"/>
<point x="999" y="1077"/>
<point x="888" y="1200"/>
<point x="704" y="1200" type="curve"/>
<point x="392" y="1200" type="line" smooth="yes"/>
<point x="320" y="1200"/>
<point x="248" y="1217"/>
</contour>
<contour>
<point x="999" y="0" type="line"/>
<point x="999" y="877" type="line"/>
<point x="766" y="754" type="line"/>
<point x="766" y="0" type="line"/>
</contour>
</outline>
<lib>
<dict>
<key>public.markColor</key>
<string>0.98,0.36,0.67,1</string>
</dict>
</lib>
</glyph>
50 changes: 50 additions & 0 deletions sources/CascadiaCode-Bold.ufo/glyphs.-10/kaf-hb.glif
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
<?xml version='1.0' encoding='UTF-8'?>
<glyph name="kaf-hb" format="2">
<advance width="1044"/>
<unicode hex="05DB"/>
<guideline x="79" y="806" angle="90"/>
<outline>
<contour>
<point x="415" y="930" type="line"/>
<point x="449" y="930" type="line"/>
<point x="632" y="926"/>
<point x="691" y="873"/>
<point x="691" y="638" type="curve"/>
<point x="924" y="790" type="line"/>
<point x="924" y="1060"/>
<point x="787" y="1200"/>
<point x="493" y="1200" type="curve" smooth="yes"/>
<point x="415" y="1200" type="line"/>
</contour>
<contour>
<point x="924" y="0" type="line"/>
<point x="924" y="809" type="line"/>
<point x="691" y="653" type="line"/>
<point x="691" y="0" type="line"/>
</contour>
<contour>
<point x="458" y="1200" type="line"/>
<point x="343" y="1200" type="line" smooth="yes"/>
<point x="287" y="1200"/>
<point x="223" y="1217"/>
<point x="183" y="1233" type="curve"/>
<point x="95" y="988" type="line"/>
<point x="142" y="960"/>
<point x="244" y="930"/>
<point x="332" y="930" type="curve" smooth="yes"/>
<point x="432" y="930" type="line"/>
</contour>
<contour>
<point x="924" y="270" type="line"/>
<point x="80" y="270" type="line"/>
<point x="80" y="0" type="line"/>
<point x="924" y="0" type="line"/>
</contour>
</outline>
<lib>
<dict>
<key>public.markColor</key>
<string>0.98,0.36,0.67,1</string>
</dict>
</lib>
</glyph>
43 changes: 43 additions & 0 deletions sources/CascadiaCode-Bold.ufo/glyphs.-10/lamed-hb.glif
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<?xml version='1.0' encoding='UTF-8'?>
<glyph name="lamed-hb" format="2">
<advance width="992"/>
<unicode hex="05DC"/>
<outline>
<contour>
<point x="350" y="-19" type="line"/>
<point x="744" y="56"/>
<point x="892" y="257"/>
<point x="892" y="652" type="curve" smooth="yes"/>
<point x="892" y="810" type="line"/>
<point x="649" y="810" type="line"/>
<point x="649" y="752" type="line" smooth="yes"/>
<point x="649" y="437"/>
<point x="586" y="308"/>
<point x="291" y="249" type="curve"/>
</contour>
<contour>
<point x="303" y="1106" type="line"/>
<point x="303" y="1500" type="line"/>
<point x="60" y="1500" type="line"/>
<point x="60" y="1106" type="line"/>
</contour>
<contour>
<point x="892" y="1200" type="line"/>
<point x="60" y="1200" type="line"/>
<point x="60" y="930" type="line"/>
<point x="892" y="930" type="line"/>
</contour>
<contour>
<point x="892" y="806" type="line"/>
<point x="892" y="1200" type="line"/>
<point x="649" y="1200" type="line"/>
<point x="649" y="806" type="line"/>
</contour>
</outline>
<lib>
<dict>
<key>public.markColor</key>
<string>0.98,0.36,0.67,1</string>
</dict>
</lib>
</glyph>
25 changes: 25 additions & 0 deletions sources/CascadiaCode-Bold.ufo/glyphs.-10/layerinfo.plist
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<?xml version='1.0' encoding='UTF-8'?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>lib</key>
<dict>
<key>com.schriftgestaltung.layerId</key>
<string>6D474A03-3D92-4EFA-9F63-B09AD4772F38</string>
<key>com.schriftgestaltung.layerOrderInGlyph.he-hb</key>
<integer>3</integer>
<key>com.schriftgestaltung.layerOrderInGlyph.het-hb</key>
<integer>4</integer>
<key>com.schriftgestaltung.layerOrderInGlyph.kaf-hb</key>
<integer>3</integer>
<key>com.schriftgestaltung.layerOrderInGlyph.lamed-hb</key>
<integer>3</integer>
<key>com.schriftgestaltung.layerOrderInGlyph.shin-hb</key>
<integer>5</integer>
<key>com.schriftgestaltung.layerOrderInGlyph.tav-hb</key>
<integer>3</integer>
<key>com.schriftgestaltung.layerOrderInGlyph.yod-hb</key>
<integer>3</integer>
</dict>
</dict>
</plist>
57 changes: 57 additions & 0 deletions sources/CascadiaCode-Bold.ufo/glyphs.-10/shin-hb.glif
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
<?xml version='1.0' encoding='UTF-8'?>
<glyph name="shin-hb" format="2">
<advance width="1123"/>
<unicode hex="05E9"/>
<outline>
<contour>
<point x="130" y="0" type="line"/>
<point x="208" y="0"/>
<point x="310" y="0"/>
<point x="375" y="0" type="curve" smooth="yes"/>
<point x="876" y="0"/>
<point x="1003" y="238"/>
<point x="1003" y="608" type="curve" smooth="yes"/>
<point x="1003" y="1200" type="line"/>
<point x="760" y="1200" type="line"/>
<point x="760" y="608" type="line" smooth="yes"/>
<point x="760" y="385"/>
<point x="697" y="270"/>
<point x="310" y="270" type="curve" smooth="yes"/>
<point x="286" y="270"/>
<point x="156" y="270"/>
<point x="130" y="270" type="curve"/>
</contour>
<contour>
<point x="472" y="818" type="line" smooth="yes"/>
<point x="472" y="680"/>
<point x="463" y="624"/>
<point x="417" y="624" type="curve" smooth="yes"/>
<point x="400" y="624"/>
<point x="379" y="630"/>
<point x="372" y="639" type="curve"/>
<point x="375" y="784" type="line"/>
<point x="303" y="492" type="line"/>
<point x="333" y="563" type="line"/>
<point x="353" y="520"/>
<point x="419" y="473"/>
<point x="476" y="473" type="curve" smooth="yes"/>
<point x="595" y="473"/>
<point x="665" y="568"/>
<point x="665" y="809" type="curve" smooth="yes"/>
<point x="665" y="1200" type="line"/>
<point x="472" y="1200" type="line"/>
</contour>
<contour>
<point x="383" y="0" type="line"/>
<point x="373" y="1200" type="line"/>
<point x="130" y="1200" type="line"/>
<point x="130" y="0" type="line"/>
</contour>
</outline>
<lib>
<dict>
<key>public.markColor</key>
<string>0.98,0.36,0.67,1</string>
</dict>
</lib>
</glyph>
Loading

0 comments on commit b0a6b2a

Please sign in to comment.