Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context menu to rich edit to allow for keyboard support #854

Merged

Conversation

EriWong
Copy link
Contributor

@EriWong EriWong commented Dec 6, 2019

Fixes part of #338.

Description of the changes:

  • Adds context menu for rich edit that allows for showing key graph features, changing colors of equations, removing equations.

How changes were validated:

manually tested keyboard only interactions
manually tested mouse interactions

@EriWong EriWong added the graphing calculator Work items related to the graphing calculator feature. label Dec 6, 2019
Copy link
Contributor

@joseartrivera joseartrivera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Works really well from my testing. Left a few comments for you to consider. Thanks!

src/Calculator/App.xaml Show resolved Hide resolved
src/Calculator/Controls/EquationTextBox.cpp Outdated Show resolved Hide resolved
src/Calculator/Controls/EquationTextBox.cpp Show resolved Hide resolved
src/Calculator/App.xaml Show resolved Hide resolved
src/Calculator/Controls/EquationTextBox.cpp Show resolved Hide resolved
src/Calculator/Controls/EquationTextBox.cpp Show resolved Hide resolved
@EriWong EriWong merged commit 4bb5c39 into microsoft:feature/GraphingCalculator Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphing calculator Work items related to the graphing calculator feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants