Update share output #782
Merged
Update share output #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseartrivera
added
the
graphing calculator
rudyhuyn
suggested changes
Nov 7, 2019
There was a problem hiding this comment.
Thank Pepe for taking care of that! I added some NIT comments, accessibility improvement and typo to fix. Let me know if you have questions!
Note: Once this part will be localized, we should make sure the HTML will be correctly formatted with none-ASCII characters (chinese, japanese, ...) and RtL languages *(arabian, hebrew,...)
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp
Outdated
Show resolved
Hide resolved
ghost
added
the
DavidShoe
reviewed
Nov 7, 2019
|
It looks like you have an extra space for an equation that shouldn't be there. It shows up in mail, but not in OneNote.
|
Fixed, I think it's because I had an unnecessary open table tag |
sanderl
approved these changes
Nov 19, 2019
|
Perfect! Thanks a lot! |
rudyhuyn
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #338
Description of the changes:
How changes were validated: