Support high contrast for color picker and fix crashing bug #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseartrivera
added
the
graphing calculator
sanderl
approved these changes
Nov 5, 2019
| <SolidColorBrush x:Key="EquationBrush14" Color="#FF018574"/> | ||
| <SolidColorBrush x:Key="EquationBrush15" Color="#FF10893E"/> | ||
| <SolidColorBrush x:Key="EquationBrush16" Color="#FF000000"/> | ||
| <!-- TODO: Figure out what colors we can use in high contrast --> |
There was a problem hiding this comment.
Do you still need this todo?
There was a problem hiding this comment.
Yeah, I just randomly picked these for now. Some of them don't work too well because currently the graph is always white. Unclear what the plan is for that in high contrast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #338
Description of the changes:
How changes were validated: