Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure consistent margins/padding with currency converter keypad #566

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

HowardWolosky
Copy link
Member

Fixes #87.

Description of the changes:

  • Simplifies the layout of ConverterNumPad to match that seen of NumpadPanel in Calculator.xaml.
    • They now both use the same static margin ('3,0,3,3)
    • Removed two "gutter" columns that had been used for dynamic margins.

The GutterLeft and GutterRight columns were left untouched on purpose.
They are only activated when in a "landscape" width/height orientation, used to ensure that the app display is evenly split 50/50 between the input fields and the number pad.
GutterLeft gives a margin to the input field column, while GutterRight is used to ensure that the number pad column has an equal width available to it (as the numberpad is displayed in a column span that merges its column with that of GutterRight.

How changes were validated:

  • Validated with a "screen ruler" that the left/right/bottom margins were the same within Volume.

Volume (before and after)

  • Validated with a "screen ruler" that the left/top/bottom in Volume were identical to those seen in Standard mode.
    Existing standard vs new Volume

  • Verified the margins in "wide" mode as well
    Volume (wide) (before and after)

Simplifies the layout of `ConverterNumPad` to match that
seen of `NumpadPanel` in Calculator.xaml by using the same
static margin and removing the use of columns that had been used
for dynamic margins.

Fixes microsoft#87
Copy link
Contributor

@joseartrivera joseartrivera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for making this change! 👍

@mdtauk
Copy link

mdtauk commented Jun 25, 2019

These converter pages should reuse the same Number Pad, and screen layout. Perhaps there should be a template page included so future additional pages will be consistent.

@grochocki
Copy link
Contributor

These converter pages should reuse the same Number Pad, and screen layout.

Visually, it is the same Number Pad, no? I agree this should be one component, if it is not already.

IRT overall page layout, I think we need to consider a broader redesign of the converter interface. I touch on that here a bit here, but I think there might be an opportunity to collapse converters so instead of navigating to an entirely different page, you can change between units on one page.

@HowardWolosky HowardWolosky merged commit 25708f0 into microsoft:master Jun 28, 2019
@HowardWolosky HowardWolosky deleted the conversionMargins branch June 28, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uneven NumberPad Margin in Converter Mode
5 participants