Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WinAppDriver UI Tests to the Calculator Project. #411

Merged
merged 7 commits into from
Apr 25, 2019

Conversation

hassanuz
Copy link
Contributor

@hassanuz hassanuz commented Mar 29, 2019

Summary

This pull requests adds WinAppDriver UI tests onto the Calculator project. Nothing in the Calculator source itself was modified outside of introducing the *\src\CalculatorWADTests* directory with the added WinAppDriver solution.

How changes were validated:

  • The tests were validated on my local machine & on the hosted VS2019 agent.

Fixes #461

@mcooley mcooley self-assigned this Apr 1, 2019
Copy link
Member

@mcooley mcooley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this, @hassanuz! I'm excited to get some UI tests in Calculator that others will be able to run. A few requests for changes, most of them fairly minor.

TODO for me: get an issue filed for this Done! #461

build/pipelines/templates/run-wad-tests.yaml Outdated Show resolved Hide resolved
build/pipelines/templates/run-wad-tests.yaml Outdated Show resolved Hide resolved
build/pipelines/templates/run-wad-tests.yaml Outdated Show resolved Hide resolved
build/pipelines/templates/run-wad-tests.yaml Outdated Show resolved Hide resolved
build/pipelines/templates/run-wad-tests.yaml Outdated Show resolved Hide resolved
src/CalculatorWADTests/ScenarioStandard.cs Outdated Show resolved Hide resolved
src/CalculatorWADTests/ScenarioStandard.cs Outdated Show resolved Hide resolved
src/CalculatorWADTests/ScenarioStandard.cs Outdated Show resolved Hide resolved
src/CalculatorWADTests/ScenarioStandard.cs Outdated Show resolved Hide resolved
src/CalculatorWADTests/packages.config Outdated Show resolved Hide resolved
sanderl
sanderl previously requested changes Apr 3, 2019
Copy link
Contributor

@sanderl sanderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@mcooley
Copy link
Member

mcooley commented Apr 25, 2019

@hassanuz I pushed some changes:

  • Integrated your work into our existing builds, so UI tests get run for PR and CI
  • Switch from .NET Framework to .NET Core
  • Switch to the official Appium.WebDriver NuGet package
  • Remove "Any CPU" as a solution configuration
  • Simplify inline powershell in the YAML

I think this is ready to merge now! @sanderl can you review again and make sure this looks OK to you?

@mcooley mcooley requested a review from sanderl April 25, 2019 14:01
@mcooley mcooley dismissed sanderl’s stale review April 25, 2019 23:45

Dismissing stale review.

@mcooley mcooley merged commit 8e1a147 into microsoft:master Apr 25, 2019
EriWong pushed a commit to EriWong/calculator that referenced this pull request Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UI tests using WinAppDriver
3 participants