Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back history editing #163

Open
miloush opened this issue Mar 7, 2019 · 8 comments
Open

Bring back history editing #163

miloush opened this issue Mar 7, 2019 · 8 comments
Labels
Enhancement help wanted Issues identified as good community contribution opportunities needs spec Pri: 2

Comments

@miloush
Copy link

miloush commented Mar 7, 2019

Problem Statement
Expressions in the history cannot be edited.

Evidence or User Insights
This is a regression from the Win32 app. Requested by #150 and part of #139. I am pretty sure it used to be in Feedback Hub too, but that seems to have been deleted now.
image

Proposal
When adding a larger number of numbers (e.g. several invoices) and a mistake is discovered, the user now has to re-enter everything again. This proposal allows them to correct the isolated error within longer expression.

Goals
User can fix errors and/or typos in past computations.

Non-Goals
This is not a symbolic evaluation proposal, surrounding history entries are not affected by edits in the current one.

Low-Fidelity Concept
While Win32 calculator allowed expressions in-place, adding Edit item to the current Delete item in the history context menu would do. The expression would then turn into a text box.

(An alternative yet still enabling solution would be to introduce Copy to clipboard on the history items. The user could then fix the expressions out of the app and paste back as new ones.)

@MicrosoftIssueBot
Copy link
Collaborator

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.

@grochocki
Copy link
Contributor

Thanks for the feature suggestion! This is really well thought-out, and we really appreciate it. Let's keep this idea open for discussion so the community has the chance to provide feedback. Check out our New Feedback Process for more info on the user-centered process we follow for new feature development.

@lukeu
Copy link

lukeu commented Mar 12, 2019

Just to say I had considered including #277 in this discussion, as I considered them part of the same "regression" with history. In the end I created a separate issue to flesh out the detail more. Perhaps it'd be worth considering both during design so they can work together nicely if both could get done(?)

@grochocki
Copy link
Contributor

They are definitely related. I think it would be good to keep them both in mind to see if they can compliment each other, but they do feel like distinct ideas. Let's keep them separate for now and see where the dsicussion leads us.

@ghost
Copy link

ghost commented Jun 5, 2019

We reviewed the pitch and would love to explore this idea further! The pitch is a great start, but there are still some open questions. Moving this into planning to iron out some of those details. A human will follow up with some feedback on your pitch shortly. Keep in mind that not all ideas that make it into the planning phase are guaranteed to make it to release. For more information on next steps, check out our spec workflow.

@grochocki
Copy link
Contributor

We believe there is a dependency on #526 that may prevent us from implementing this feature today. Having said that, we should think through the experience we want to provide to help us better understand requirements for #526. I created calculator-specs/historyEditing to track progress.

@oatesch
Copy link

oatesch commented Mar 10, 2021

#526 appears to be large in scope, including NLP and custom operators.
Is this beyond what is required to implement editable history, as per Windows 7?

Can #526 be reduced to the minimum required to implement #163 ? Or can this issue be progressed without #526 being completed?

@alonsoac
Copy link

I recently upgraded from Windows 8 to 11 and can´t believe the calculator is less useful than before. Editing the history was a basic feature. How much would it cost for someone to fix this? Just basic editing in the standard mode is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement help wanted Issues identified as good community contribution opportunities needs spec Pri: 2
Projects
None yet
Development

No branches or pull requests

6 participants