This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
Fix build bug from VA & replace asset images #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes png images and replaces with base64 samples
lauren-mills
suggested changes
Mar 28, 2019
solutions/Virtual-Assistant/src/csharp/assistant/Dialogs/Main/Resources/MainDialogResponses.tt
Outdated
Show resolved
Hide resolved
lauren-mills
approved these changes
Mar 28, 2019
DingmaomaoBJTU
added a commit
that referenced
this pull request
Apr 2, 2019
* Adapt i18next to load locales from other solutions (#979) * [Skill Template][TypeScript] Fix Placeholder replacements (#1002) * Fix deploymentScripts paths * Update placeholder replacements for bot.recipe files * Add tests for the bot.recipe files * Automotive: Use YAML instead of JSON files for list of settings (#1008) * add locale bots files to copy (#1009) * make adapters transient (#1011) * address warnings (stylecop) (#1012) * [Virtual Assistant][TypeScript] Update core functionality (#999) * Update CognitiveModels and DepoymentScripts * Add resources files * Update dialogs * Update remaining 'assistant' files * Update authentication, middleware and responses * Update proactive, skills, util and extensions folders, index.ts and npm-srinkwrap files * Fix some TSLint warnings * Add backgroundTaskQueue * Update logic for using skills with InProc approach * docs(README): correct Bot Framework link (#1015) * fix qna inputhint issue (#1014) * move Microsoft.Bot.Builder.Solutions into a subfolder under lib/csharp (#1019) * Add dynamic list card support in microsoft.bot.builder.solutions (#1017) * add card support * resolve merge conflict * Add deployment steps for VA (#1025) * Update INTRO_PATH to be Mac/unix friendly (#1021) Running the Enterprise Template project in VS Code on a Mac throws a runtime error due to the Intro.json file not being found caused by the Windows forward-slash not being interpreted into the path. Swapping the forward-slashes for back-slashes solves this issue and continues to function on Windows w/out issue. * [Virtual Assistant][TypeScript] Implement SampleSkill to test Virtual Assistant (#1024) * Merge branch 'southworks/virtual-assistant/sample-skill' into southworks/virtual-assistant/test-migration-with-sampleskill * Fix for latest changes * Fix minimum score for topIntent in sampleSkill * Fix SampleSkill index * Fix SampleSkill to work as standalone bot * Fix tslint warnings * Fix for i18next implementation and minor fix in ResponseManager initialization * [Virtual Assistant][TypeScript] Implement Virtual Assistant Tests (#1007) * Accept test bot files * Add nock dependency * Add rush test script * Add mock resources * Add nockFixtures * Add test environment * Add mocha file to run the tests * Add configuration test files * Add Assistant tests * Implement i18next * Adaptive Card update for VA (#1022) * Added MainDialogResponses for new intro card text, GreetingCardModel for card properties, image assets for card. * Added MainDialogResponses for new intro card text, GreetingCardModel for card properties, image assets for card. * Removed intro json Added user greeting cards mapping to model. Updated onboarding dialog to only ask for name for quick personalisation & to remember returning user. * added translated strings for main dialgo responses * Updated image assets and passing wwwroot references to cards. Updated VA tests * Removed bad merge * revert _accessors name * Removed incorrect spaces in zh-cn responses * Updated to aka.ms links * Fix build bug from VA & replace asset images (#1035) * Fixed .t4 reference causing build bug Removes png images and replaces with base64 samples * Removed HttpContext and ImagePathLocation dependencies in VA * Added shared ResponseIdCollection resource * Point of Interest Adaptive Cards (#1037) * Added new POIDetails card * Header: using new method of bg image set to a single column for the entire header. Background: full white bg. Adjusted the image dimensions to Azure maps results to match new card and maintain consistent card heights. * Removed poi source enum and replaced with string Updated cards. * Adding hashset of providers * Updated returning uesr greeting * Updated Powered by string for maps * Updated unit tests * Added localization for poi shared strings. * fixed directory refs in solutions * [Skill Template][TypeScript] Implement tests and fixes (#1038) * Update the _index.ts file and add placeholders * Implement standalone functionality * Fix responseManager initialization and reorder imports * Add tests to the generator for the index changes * Update Skill Template, rename resources files * Update generator-botbuilder-skill * Add new tests for the generator-botbuilder-skill * [Skill Template][TypeScript] Fix Placeholder replacements (#1002) * Fix deploymentScripts paths * Update placeholder replacements for bot.recipe files * Add tests for the bot.recipe files * Add the main functionality and structure of the tests * Implement i18next, fix tslint errors * Update generator-botbuilder-skill to use new template files * Add generator-botbuilder-skill tests * Add new placeholders for testAdapter initialization * Delete duplicated variable * [Email Skill]Adaptive Card update with Graph API (#1029) * adaptive card prototype * test * add detail card * overall card support * add default avatar * apply new cards with condition * add recipient icon display support * show important and attachment icon * add locale support * modify icon size to fit bg image * Added id and medium spacing to the email overview by condition card * Delete ResponseManager.cs * updated nuget to latest * update with new design * fix UT * add google support * fix comments * fix google api but * fix adaptive card * fix as comments * fix comments
DingmaomaoBJTU
pushed a commit
that referenced
this pull request
Apr 4, 2019
* add new adaptive card * change card bg to base64 and show blank icon when no location * fix test error * Qiowu/fix calendar adaptive card (#1042) * Adapt i18next to load locales from other solutions (#979) * [Skill Template][TypeScript] Fix Placeholder replacements (#1002) * Fix deploymentScripts paths * Update placeholder replacements for bot.recipe files * Add tests for the bot.recipe files * Automotive: Use YAML instead of JSON files for list of settings (#1008) * add locale bots files to copy (#1009) * make adapters transient (#1011) * address warnings (stylecop) (#1012) * [Virtual Assistant][TypeScript] Update core functionality (#999) * Update CognitiveModels and DepoymentScripts * Add resources files * Update dialogs * Update remaining 'assistant' files * Update authentication, middleware and responses * Update proactive, skills, util and extensions folders, index.ts and npm-srinkwrap files * Fix some TSLint warnings * Add backgroundTaskQueue * Update logic for using skills with InProc approach * docs(README): correct Bot Framework link (#1015) * fix qna inputhint issue (#1014) * move Microsoft.Bot.Builder.Solutions into a subfolder under lib/csharp (#1019) * Add dynamic list card support in microsoft.bot.builder.solutions (#1017) * add card support * resolve merge conflict * Add deployment steps for VA (#1025) * Update INTRO_PATH to be Mac/unix friendly (#1021) Running the Enterprise Template project in VS Code on a Mac throws a runtime error due to the Intro.json file not being found caused by the Windows forward-slash not being interpreted into the path. Swapping the forward-slashes for back-slashes solves this issue and continues to function on Windows w/out issue. * [Virtual Assistant][TypeScript] Implement SampleSkill to test Virtual Assistant (#1024) * Merge branch 'southworks/virtual-assistant/sample-skill' into southworks/virtual-assistant/test-migration-with-sampleskill * Fix for latest changes * Fix minimum score for topIntent in sampleSkill * Fix SampleSkill index * Fix SampleSkill to work as standalone bot * Fix tslint warnings * Fix for i18next implementation and minor fix in ResponseManager initialization * [Virtual Assistant][TypeScript] Implement Virtual Assistant Tests (#1007) * Accept test bot files * Add nock dependency * Add rush test script * Add mock resources * Add nockFixtures * Add test environment * Add mocha file to run the tests * Add configuration test files * Add Assistant tests * Implement i18next * Adaptive Card update for VA (#1022) * Added MainDialogResponses for new intro card text, GreetingCardModel for card properties, image assets for card. * Added MainDialogResponses for new intro card text, GreetingCardModel for card properties, image assets for card. * Removed intro json Added user greeting cards mapping to model. Updated onboarding dialog to only ask for name for quick personalisation & to remember returning user. * added translated strings for main dialgo responses * Updated image assets and passing wwwroot references to cards. Updated VA tests * Removed bad merge * revert _accessors name * Removed incorrect spaces in zh-cn responses * Updated to aka.ms links * Fix build bug from VA & replace asset images (#1035) * Fixed .t4 reference causing build bug Removes png images and replaces with base64 samples * Removed HttpContext and ImagePathLocation dependencies in VA * Added shared ResponseIdCollection resource * Point of Interest Adaptive Cards (#1037) * Added new POIDetails card * Header: using new method of bg image set to a single column for the entire header. Background: full white bg. Adjusted the image dimensions to Azure maps results to match new card and maintain consistent card heights. * Removed poi source enum and replaced with string Updated cards. * Adding hashset of providers * Updated returning uesr greeting * Updated Powered by string for maps * Updated unit tests * Added localization for poi shared strings. * fixed directory refs in solutions * [Skill Template][TypeScript] Implement tests and fixes (#1038) * Update the _index.ts file and add placeholders * Implement standalone functionality * Fix responseManager initialization and reorder imports * Add tests to the generator for the index changes * Update Skill Template, rename resources files * Update generator-botbuilder-skill * Add new tests for the generator-botbuilder-skill * [Skill Template][TypeScript] Fix Placeholder replacements (#1002) * Fix deploymentScripts paths * Update placeholder replacements for bot.recipe files * Add tests for the bot.recipe files * Add the main functionality and structure of the tests * Implement i18next, fix tslint errors * Update generator-botbuilder-skill to use new template files * Add generator-botbuilder-skill tests * Add new placeholders for testAdapter initialization * Delete duplicated variable * [Email Skill]Adaptive Card update with Graph API (#1029) * adaptive card prototype * test * add detail card * overall card support * add default avatar * apply new cards with condition * add recipient icon display support * show important and attachment icon * add locale support * modify icon size to fit bg image * Added id and medium spacing to the email overview by condition card * Delete ResponseManager.cs * updated nuget to latest * update with new design * fix UT * add google support * fix comments * fix google api but * fix adaptive card * fix as comments * fix comments * Revert "Qiowu/fix calendar adaptive card (#1042)" This reverts commit 5e5d8d0. * fix build error after merge * add google support
lauren-mills
pushed a commit
that referenced
this pull request
Apr 18, 2019
* Fixed .t4 reference causing build bug Removes png images and replaces with base64 samples * Removed HttpContext and ImagePathLocation dependencies in VA * Added shared ResponseIdCollection resource
lauren-mills
pushed a commit
that referenced
this pull request
Apr 18, 2019
* add new adaptive card * change card bg to base64 and show blank icon when no location * fix test error * Qiowu/fix calendar adaptive card (#1042) * Adapt i18next to load locales from other solutions (#979) * [Skill Template][TypeScript] Fix Placeholder replacements (#1002) * Fix deploymentScripts paths * Update placeholder replacements for bot.recipe files * Add tests for the bot.recipe files * Automotive: Use YAML instead of JSON files for list of settings (#1008) * add locale bots files to copy (#1009) * make adapters transient (#1011) * address warnings (stylecop) (#1012) * [Virtual Assistant][TypeScript] Update core functionality (#999) * Update CognitiveModels and DepoymentScripts * Add resources files * Update dialogs * Update remaining 'assistant' files * Update authentication, middleware and responses * Update proactive, skills, util and extensions folders, index.ts and npm-srinkwrap files * Fix some TSLint warnings * Add backgroundTaskQueue * Update logic for using skills with InProc approach * docs(README): correct Bot Framework link (#1015) * fix qna inputhint issue (#1014) * move Microsoft.Bot.Builder.Solutions into a subfolder under lib/csharp (#1019) * Add dynamic list card support in microsoft.bot.builder.solutions (#1017) * add card support * resolve merge conflict * Add deployment steps for VA (#1025) * Update INTRO_PATH to be Mac/unix friendly (#1021) Running the Enterprise Template project in VS Code on a Mac throws a runtime error due to the Intro.json file not being found caused by the Windows forward-slash not being interpreted into the path. Swapping the forward-slashes for back-slashes solves this issue and continues to function on Windows w/out issue. * [Virtual Assistant][TypeScript] Implement SampleSkill to test Virtual Assistant (#1024) * Merge branch 'southworks/virtual-assistant/sample-skill' into southworks/virtual-assistant/test-migration-with-sampleskill * Fix for latest changes * Fix minimum score for topIntent in sampleSkill * Fix SampleSkill index * Fix SampleSkill to work as standalone bot * Fix tslint warnings * Fix for i18next implementation and minor fix in ResponseManager initialization * [Virtual Assistant][TypeScript] Implement Virtual Assistant Tests (#1007) * Accept test bot files * Add nock dependency * Add rush test script * Add mock resources * Add nockFixtures * Add test environment * Add mocha file to run the tests * Add configuration test files * Add Assistant tests * Implement i18next * Adaptive Card update for VA (#1022) * Added MainDialogResponses for new intro card text, GreetingCardModel for card properties, image assets for card. * Added MainDialogResponses for new intro card text, GreetingCardModel for card properties, image assets for card. * Removed intro json Added user greeting cards mapping to model. Updated onboarding dialog to only ask for name for quick personalisation & to remember returning user. * added translated strings for main dialgo responses * Updated image assets and passing wwwroot references to cards. Updated VA tests * Removed bad merge * revert _accessors name * Removed incorrect spaces in zh-cn responses * Updated to aka.ms links * Fix build bug from VA & replace asset images (#1035) * Fixed .t4 reference causing build bug Removes png images and replaces with base64 samples * Removed HttpContext and ImagePathLocation dependencies in VA * Added shared ResponseIdCollection resource * Point of Interest Adaptive Cards (#1037) * Added new POIDetails card * Header: using new method of bg image set to a single column for the entire header. Background: full white bg. Adjusted the image dimensions to Azure maps results to match new card and maintain consistent card heights. * Removed poi source enum and replaced with string Updated cards. * Adding hashset of providers * Updated returning uesr greeting * Updated Powered by string for maps * Updated unit tests * Added localization for poi shared strings. * fixed directory refs in solutions * [Skill Template][TypeScript] Implement tests and fixes (#1038) * Update the _index.ts file and add placeholders * Implement standalone functionality * Fix responseManager initialization and reorder imports * Add tests to the generator for the index changes * Update Skill Template, rename resources files * Update generator-botbuilder-skill * Add new tests for the generator-botbuilder-skill * [Skill Template][TypeScript] Fix Placeholder replacements (#1002) * Fix deploymentScripts paths * Update placeholder replacements for bot.recipe files * Add tests for the bot.recipe files * Add the main functionality and structure of the tests * Implement i18next, fix tslint errors * Update generator-botbuilder-skill to use new template files * Add generator-botbuilder-skill tests * Add new placeholders for testAdapter initialization * Delete duplicated variable * [Email Skill]Adaptive Card update with Graph API (#1029) * adaptive card prototype * test * add detail card * overall card support * add default avatar * apply new cards with condition * add recipient icon display support * show important and attachment icon * add locale support * modify icon size to fit bg image * Added id and medium spacing to the email overview by condition card * Delete ResponseManager.cs * updated nuget to latest * update with new design * fix UT * add google support * fix comments * fix google api but * fix adaptive card * fix as comments * fix comments * Revert "Qiowu/fix calendar adaptive card (#1042)" This reverts commit 5e5d8d0. * fix build error after merge * add google support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug Fixes
Fixed build bug with MainResponses looking for
.t4file in wrong location.Maintenance
Replaced locally hosted images with base64 encoded images, which removes extra httpcontext depencencies.
#916
Checklist