Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#1514] Port JS CLU Recognizer unit tests #1521

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #1514

This PR depends on #1518 which contains the JS CLU Recognizer, and must be merged after this one.

Purpose

This PR ports the CLU Recognizer's unit tests from .NET to JS.

Changes

  • Added new js folder under the tests/unit/packages/Recognizers directory.
  • Added config files tsconfig.json and package.json for the new test project.
  • Added unit tests for the following classes:
    • CluApplication
    • CluExtensions
    • CluRecognizerOptions
    • CluRecognizerOptionsBase
    • DefaultHttpClientFactory

Tests

This image shows the new unit tests passing.
image

@tracyboehrer tracyboehrer merged commit 9894bff into main Aug 7, 2023
2 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the southworks/add/js-clu-recognizer-tests branch August 7, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port DotNet CLU Recognizer component to JS
2 participants