This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
Expose import resolver interface for cross-train/luis:build/qnamaker:build #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #935 +/- ##
==========================================
- Coverage 72.12% 69.29% -2.83%
==========================================
Files 175 175
Lines 10754 9051 -1703
Branches 900 887 -13
==========================================
- Hits 7756 6272 -1484
+ Misses 2669 2420 -249
- Partials 329 359 +30
Continue to review full report at Codecov.
|
boydc2014
reviewed
Aug 13, 2020
boydc2014
approved these changes
Aug 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, @vishwacsena , @munozemilio can you help also check this one, this will help Composer to customize the interpretation of the import statements in lu or qna files. Like "import[a.lu]" or "import[b.qna]", composer can direct that import to a.en_us.lu or b.en_us.qna like that.
boydc2014
changed the title
Expose file resolver interface for cross-train/luis:build/qnamaker:build
Expose import resolver interface for cross-train/luis:build/qnamaker:build
Aug 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #934 to expose import resolver interface for cross-train/luis:build/qnamaker:build so that composer can customize their file resolving system based on their import system.