Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

Add support for URI reference in LU #923

Merged
merged 4 commits into from
Aug 5, 2020
Merged

Add support for URI reference in LU #923

merged 4 commits into from
Aug 5, 2020

Conversation

vishwacsena
Copy link
Contributor

Fixes #922

> URI to LU resource
[import](http://.../foo.lu)

# intent1
> Ability to pull in specific utterances from an intent
- [import](http://.../foo.lu#None)

# intent2
> Ability to pull in utterances or patterns or both from a specific intent 'None'
- [import](http://..../foo.lu#None*utterances*)
- [import](http://..../bar.lu#None*patterns*)
- [import](http://..../taz.lu#None*utterancesandpatterns*)

# intent3
> Ability to pull in all utterances or patterns or both across all intents
- [import](http://..../foo.lu#*utterances*)
- [import](http://..../bar.lu#*patterns*)
- [import](http://..../taz.lu#*utterancesandpatterns*)

Copy link
Contributor

@tsuwandy tsuwandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks vishwac!

@codecov-commenter
Copy link

Codecov Report

Merging #923 into master will decrease coverage by 0.69%.
The diff coverage is 61.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #923      +/-   ##
==========================================
- Coverage   56.27%   55.57%   -0.70%     
==========================================
  Files         219      220       +1     
  Lines       16541    16069     -472     
  Branches     2307     2299       -8     
==========================================
- Hits         9308     8931     -377     
+ Misses       6670     6580      -90     
+ Partials      563      558       -5     
Impacted Files Coverage Δ
packages/lu/src/parser/lu/luMerger.js 78.13% <51.35%> (+1.79%) ⬆️
packages/lu/src/parser/utils/helpers.js 87.45% <72.22%> (-2.01%) ⬇️
packages/lu/src/parser/lufile/parseFileContents.js 81.25% <100.00%> (-0.42%) ⬇️
packages/lu/src/utils/textfilereader.ts 58.33% <100.00%> (+29.76%) ⬆️
...mathematics/confusion_matrix/AppConfusionMatrix.ts 6.66% <0.00%> (-22.32%) ⬇️
...kages/qnamaker/src/commands/qnamaker/kb/publish.ts 85.71% <0.00%> (-14.29%) ⬇️
...aker/src/commands/qnamaker/endpointkeys/refresh.ts 85.71% <0.00%> (-14.29%) ⬇️
...ages/lu/src/parser/qna/alterations/qnaConverter.js 40.00% <0.00%> (-10.00%) ⬇️
packages/qnamaker/src/utils/qnamakerbase.ts 71.64% <0.00%> (-8.72%) ⬇️
packages/qnamaker/src/commands/qnamaker/query.ts 41.93% <0.00%> (-8.07%) ⬇️
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5bb0e...70fa1c6. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LU parser - add support for URIs
4 participants