This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
feich-ms
commented
Feb 25, 2020
•
edited
Loading
edited
- Rename luCrossTrainer.js to crossTrainer.js and expose cross-train.js to handle files input and output. Moved these two files to cross-train folder
- Pull fathers's qna questions to children's interruption intents
- config file of mapping rules should be specified by flags.config parameter. If not, it will read default config.json from the folder specified by --in
- Remove duplicated utterances in interruption intent to make sure it has no duplications with other intent utterances in the lu file
- Remove all duplications of lu utterances in a intent and qna questions in a qna section
This reverts commit ab1fb84.
…tframework-cli into feich/QnACrossTrain
feich-ms
changed the title
Add cross-train core library in bf-lu
cross-train core library in bf-lu
Feb 25, 2020
vishwacsena
suggested changes
Feb 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do two things -
- Remove CLI tests from BF-LU
- Add tests that directly use the API surface.
For now, since there isn't a public API in R8, we should just move CLI tests to the cross-train branch and just add few sanity tests here for the classes and methods.
@vishwacsena working on the test refactoring. Will give updates when ready. |
@vishwacsena, cross train core library related tests are refactored. The PR is ready and looks much more clean now. |
vishwacsena
approved these changes
Feb 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.