Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

cross-train core library in bf-lu #601

Merged
merged 60 commits into from
Feb 28, 2020
Merged

cross-train core library in bf-lu #601

merged 60 commits into from
Feb 28, 2020

Conversation

feich-ms
Copy link
Contributor

@feich-ms feich-ms commented Feb 25, 2020

  1. Rename luCrossTrainer.js to crossTrainer.js and expose cross-train.js to handle files input and output. Moved these two files to cross-train folder
  2. Pull fathers's qna questions to children's interruption intents
  3. config file of mapping rules should be specified by flags.config parameter. If not, it will read default config.json from the folder specified by --in
  4. Remove duplicated utterances in interruption intent to make sure it has no duplications with other intent utterances in the lu file
  5. Remove all duplications of lu utterances in a intent and qna questions in a qna section

feich-ms and others added 30 commits January 6, 2020 18:46
@feich-ms feich-ms changed the title Add cross-train core library in bf-lu cross-train core library in bf-lu Feb 25, 2020
Copy link
Contributor

@vishwacsena vishwacsena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do two things -

  1. Remove CLI tests from BF-LU
  2. Add tests that directly use the API surface.

For now, since there isn't a public API in R8, we should just move CLI tests to the cross-train branch and just add few sanity tests here for the classes and methods.

@feich-ms
Copy link
Contributor Author

@vishwacsena working on the test refactoring. Will give updates when ready.

@feich-ms
Copy link
Contributor Author

feich-ms commented Feb 27, 2020

@vishwacsena, cross train core library related tests are refactored. The PR is ready and looks much more clean now.

@feich-ms feich-ms merged commit 1edc0e2 into master Feb 28, 2020
@feich-ms feich-ms deleted the feich/QnACrossTrainCore branch February 28, 2020 03:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants