This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
chore: fix dialog debugging #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrimc62
reviewed
Nov 25, 2019
| @@ -77,14 +85,14 @@ | |||
| "type": "node", | |||
| "request": "launch", | |||
| "name": "Generate Sandwich Form", | |||
| "program": "${workspaceFolder}/bin/run", | |||
| "preLaunchTask": "tsc: build - tsconfig.json", | |||
There was a problem hiding this comment.
For this kind of thing it is definitely nice to be able to build before launching. What is the right pattern for this?
There was a problem hiding this comment.
Maybe ${defaultBuildTask}?
| "program": "${workspaceFolder}/bin/run", | ||
| "preLaunchTask": "tsc: build - tsconfig.json", | ||
| "program": "${workspaceFolder}/packages/dialog/bin/run", | ||
| "sourceMaps": true, |
There was a problem hiding this comment.
Find to be explicit, but isn't sourceMaps = true the default? For that matter, they don't even list it as an option in the docs. https://code.visualstudio.com/Docs/editor/debugging
| @@ -57,4 +38,24 @@ export default class GenerateDialog extends Command { | |||
| progress(msg: string): void { | |||
| this.error(msg) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This is annoying especially given that style rules complain about doing this. I know you have a bug out for typescript, but maybe we should disable the rule? Or maybe I shouldn't have the tslint extension...
This was referenced Apr 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Fixes the dialog debugging experience and address sourcemap issues.
Changes