Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TeamsChannelAccount model #2083

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Fix TeamsChannelAccount model #2083

merged 1 commit into from
Mar 6, 2024

Conversation

nuno-andre
Copy link
Contributor

@nuno-andre nuno-andre commented Mar 6, 2024

Fixes #2084

Fixes TeamsChannelAccount.add_object_id property.

The curent definition returns an additional property and a null add_object_id:

{'additional_property': {'aadObjectId': <UUID>}, 'add_object_id`: None}

instead of:

 {'additional_properties': {}, `add_object_id` <UUID>}

See: https://learn.microsoft.com/en-us/dotnet/api/microsoft.bot.schema.teams.teamschannelaccount?view=botbuilder-dotnet-stable

@nuno-andre nuno-andre requested a review from a team as a code owner March 6, 2024 02:24
@tracyboehrer tracyboehrer merged commit 8f1b58d into microsoft:main Mar 6, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TeamsChannelAccount model missing aadObjectId
2 participants