Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#4482][#6588] UserId not being passed to AzureDiagnostics #4493

Merged
merged 1 commit into from
Jul 14, 2023
Merged

port: [#4482][#6588] UserId not being passed to AzureDiagnostics #4493

merged 1 commit into from
Jul 14, 2023

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #4482

Description

This PR allows adding the userId property which was empty when displaying the AzureDiagnostics table in the Log Analytics workspace resource.

Specific Changes

  • Added userId property to the queryKnowledgebaseRaw request in the LanguageServiceUtils file.
  • Added userId property to the QnAMakerOptions interface.
  • Updated parameter sending of queryKnowledgebaseRaw, allowing to send the userId to the QnAMakerOptions using the context activity

Testing

The following image shows the AzureDiagnostics log with the userId value.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner June 21, 2023 13:33
@coveralls
Copy link

coveralls commented Jun 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5334766855

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.504%
Totals Coverage Status
Change from base Build 5222839148: 0.0%
Covered Lines: 20038
Relevant Lines: 22477
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit a44bfbc into main Jul 14, 2023
@tracyboehrer tracyboehrer deleted the southworks/add/userId-into-language-service branch July 14, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: [#6588] UserId not being passed to AzureDiagnostics
4 participants
@ceciliaavila @coveralls @tracyboehrer @JhontSouth