-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Teams meeting start/end events #3757
feat: add support for Teams meeting start/end events #3757
Conversation
Pull Request Test Coverage Report for Build 951068226
💛 - Coveralls |
// The payload from Teams comes in with TitleCase keys, so we'll convert them to camelCase | ||
// to maintain JSON and JS standard practices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This is intentional from Teams and not expected to change.
*/ | ||
export interface MeetingDetails { | ||
interface MeetingDetailsBase { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: These interfaces were originally introduced in the PR that added getMeetingInfo()
. Per Teams, the two schemas are intentionally different in the ways depicted below and not likely to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor things, and a suggestion to use runtypes
if you want.
Fixes #3724
Description
Adds support to TeamsActivityHandler for meeting start/end events.
Notes
Bots implementing this must add this to their
manifest.json
:Note that somebody needs to actually start/join the meeting for this to work. The scheduled start/end times mean nothing for this event.
Testing