Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Teams meeting start/end events #3757

Merged
merged 16 commits into from
Jun 18, 2021

Conversation

mdrichardson
Copy link
Contributor

@mdrichardson mdrichardson commented Jun 16, 2021

Fixes #3724

Description

Adds support to TeamsActivityHandler for meeting start/end events.

Notes

Bots implementing this must add this to their manifest.json:

"webApplicationInfo": {
        "id": "<MicrosoftAppId>",
        "resource": "<urlToApp>",
        "applicationPermissions": [
            "OnlineMeeting.ReadBasic.Chat"
        ]
    }

Note that somebody needs to actually start/join the meeting for this to work. The scheduled start/end times mean nothing for this event.

Testing

image

@mdrichardson mdrichardson changed the title [Draft] add support for Teams meeting start/end events [Draft] feat: add support for Teams meeting start/end events Jun 16, 2021
@coveralls
Copy link

coveralls commented Jun 16, 2021

Pull Request Test Coverage Report for Build 951068226

  • 17 of 17 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 85.418%

Totals Coverage Status
Change from base Build 950796702: 0.006%
Covered Lines: 19296
Relevant Lines: 21490

💛 - Coveralls

@mdrichardson mdrichardson changed the title [Draft] feat: add support for Teams meeting start/end events feat: add support for Teams meeting start/end events Jun 16, 2021
Comment on lines 1011 to 1012
// The payload from Teams comes in with TitleCase keys, so we'll convert them to camelCase
// to maintain JSON and JS standard practices.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This is intentional from Teams and not expected to change.

*/
export interface MeetingDetails {
interface MeetingDetailsBase {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: These interfaces were originally introduced in the PR that added getMeetingInfo(). Per Teams, the two schemas are intentionally different in the ways depicted below and not likely to change.

@mdrichardson mdrichardson marked this pull request as ready for review June 17, 2021 18:02
@mdrichardson mdrichardson requested a review from a team as a code owner June 17, 2021 18:02
Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor things, and a suggestion to use runtypes if you want.

libraries/botbuilder/src/teamsActivityHandler.ts Outdated Show resolved Hide resolved
libraries/botbuilder/src/teamsActivityHandler.ts Outdated Show resolved Hide resolved
libraries/botbuilder/tests/teamsActivityHandler.test.js Outdated Show resolved Hide resolved
libraries/botbuilder/src/teamsActivityHandler.ts Outdated Show resolved Hide resolved
@mdrichardson mdrichardson requested a review from stevengum as a code owner June 18, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Teams - meeting start/end events (JS)
3 participants