This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
Dialogs package #922
Merged
Dialogs package #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #743
Description
Ported code and unit tests for Dialogs, except OAuthPrompt/OAuthPromptSettings which will be done later.
Specific Changes
All code was ported from the C# base and follows the Java patterns for the Java SDK. Built and tested on Java 1.8.
Testing
All unit tests have been ported and are passing, except for a single test that fails due to an issue in the TextRecognizers library. That test is commented out for now and can be re-enabled when the recognizer fix is in place.