Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

Conversation

Batta32
Copy link
Contributor

@Batta32 Batta32 commented May 26, 2021

Fix #1211
Related to #1166

Description

We compared the structure/code migration/unit tests/documentation of the bot-ai-luis-v3 library between Java and C# and we found disparities and fixes that this PR includes.

Specific Changes

  • Remove unused application-insights dependency from pom.xml
  • Add missing unit test
  • Remove set of length to -1 as empty length is 0
  • Replace null/empty validation for isBlank/isNotBlank from StringUtils
  • Apply naming convention for Java methods (lowerCamelCase)
  • Fix javadocs and style

Testing

mvn clean install passing successfully
image

@tracyboehrer tracyboehrer merged commit 40094f9 into microsoft:main May 27, 2021
@Batta32 Batta32 deleted the external/fix/southworks/libraries/bot-ai-luis-v3/fix-disparities branch May 27, 2021 17:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SDK][Bot-AI-LUIS-V3] Disparities between C#/JavaScript and Java
2 participants