This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
[QnA] Fix MultiTurnPrompt QnA conversation #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracyboehrer
approved these changes
May 12, 2021
|
@tracyboehrer and @LeeParrishMSFT, we updated this branch adding the last changes of the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1203
Related to #1166
Description
When the MultiTurnPrompt QnA conversation is configured and executed in a Java sample (e.g. 49.qnamaker-all-features), the conversation has an infinite loop.
Specific Changes
qnaMakerClient(like JS)QNA_CONTEXT_DATAis not present in the state of the active dialog (like C#)Testing
MultiTurnPrompt working as expected
mvn clean install passing successfully
