This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
Implemented ResumeDialog in Skills #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1131
Description
Ported parts of changes for skills that were appropriate for the Skills part of these changes The adaptive parts are not needed yet as Adaptive is not part of the Java SDK.
Specific Changes
Changed SkillConverationIdFactory for Id generation, and updated SkillDialog to handle interruption from an adaptive dialog that might be calling a Skill.
Testing
Added unit tests for changes to SkillConversationIdFactory to test changes in Id creation.