This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 115
[Samples] Add 21.corebot-app-insights sample #1138
Merged
tracyboehrer
merged 20 commits into
microsoft:main
from
southworks:external/feature/southworks/samples/corebot-app-insights/base
Apr 7, 2021
Merged
[Samples] Add 21.corebot-app-insights sample #1138
tracyboehrer
merged 20 commits into
microsoft:main
from
southworks:external/feature/southworks/samples/corebot-app-insights/base
Apr 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lient to consume instrumentationKey
…app-insights/base
tracyboehrer
approved these changes
Apr 7, 2021
Batta32
deleted the
external/feature/southworks/samples/corebot-app-insights/base
branch
April 7, 2021 16:50
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #871
Description
We are adding the sample 21.corebot-app-insights in Java taking into account the C# 21.corebot-app-insights present in BotBuilder-Samples repository.
Specific Changes
resources
folderdeploymentTemplates
folderREADME
/README-LUIS
/LICENSE
documentsincludeInstanceData
property totrue
like JavaScript and PythoninstrumentationKey
and creating an active TelemetryConfiguration like JavaScriptTesting
Current behavior of the Java migrated sample in Emulator
Application Insights resource populated after communicating with the migrated sample
mvn clean install of the entire repository
mvn package of the Java migrated sample