This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
Removed references to TrustServiceUrl #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #946
Description
Removed references to TrustServiceUrl to match C# code updates.
Specific Changes
Removed one place that was checking TrustServiceUrl in AppCredentials and all places that were adding URLs to this list. Removed the list and all static values that were part of the list. The only change of any effect will be we no longer check in AppCredentials if a URL is in the list in shouldSetToken and will just return true where in the past we checked to see if the URL was in the trusted list.
Testing
All unit tests were updated and run to validate this change.