-
Notifications
You must be signed in to change notification settings - Fork 115
[SDK][Bot-Azure] Add AzureQueueStorage component #1033
[SDK][Bot-Azure] Add AzureQueueStorage component #1033
Conversation
Hi @tracyboehrer, the unit test for this implementation requires Azure Storage Emulator, just like the CosmosDbPartitionedStorage. We found this prep-test in BotBuilder JS, similar to CosmosDbPartitionedStorage. |
try { | ||
queueClient.create(); | ||
} catch (QueueStorageException e) { | ||
e.printStackTrace(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it acceptable for the code to continue at this point or should we return here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LeeParrishMSFT, we will review this and apply the corresponding fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LeeParrishMSFT, we improved this behaviour to throw a RuntimeException
like the CosmosDbPartitionedStorage does.
@Batta32 Can you change this, and the other Storage impl to follow the pattern in CosmosDbPartitionStorageTests. I changed 'assertEmulator' to 'runIfEmulator'. The relevant code is:
Then (for example):
|
Sure @tracyboehrer, we will apply those changes to follow the pattern of |
* Apply Tracy's feedback * Update libraries/bot-azure/src/test/java/com/microsoft/bot/azure/AzureQueueTests.java Co-authored-by: Martin Battaglino <[email protected]> Co-authored-by: Martin Battaglino <[email protected]>
@tracyboehrer, we finished applying the requested change here and also, we merged We will continue working on the PR #1066. |
@tracyboehrer we were able to reproduce the error 400 by downgrading the azure-storage-queue to a previous version (12.0.0). We also tested from version 12.1.0 to 12.8.0, and the error is not present when using the Azure Storage Emulator v5.10.0. The issue seems to be a mismatch between the version of the emulator and of the library. |
@VictorGrycuk OK. I think we have this sorted out. At least the PR build succeeded. If you can update from main again I promise we'll get this merged. |
@tracyboehrer done! The build passed 🎉! |
Fixes #909
Description
Implements AzureQueueStorage class and its unit test. This PR also fixes a few disparities with C# present in different classes.
Specific Changes
getContinuationActivity()
methodConfirmPrompt_Locale_Override_ChoiceDefaults
of ConfirmPromptLocTests, by adding a missing assignation of the custom localeTesting
These implementations were successfully validated by running the build and unit tests