Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable telemetry adaptive sampling #6849

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

JhontSouth
Copy link
Collaborator

#minor

Description

This PR disables the adaptive sampling used in the telemetry client to avoid skipping logs due to big amount of concurrent users and events.

Specific Changes

  • Set to false property EnableAdaptiveSampling of telemetry settings in ServiceCollectionExtensions classes.

Testing

The following image shows the logs saved correctly in the Application Insights resource.
image

@JhontSouth JhontSouth requested a review from a team as a code owner September 16, 2024 15:54
@JhontSouth JhontSouth added the Automation: No parity PR does not need to be applied to other languages. label Sep 16, 2024
@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll

@tracyboehrer tracyboehrer merged commit 6d584df into main Sep 17, 2024
11 of 12 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/telemetry-sampling branch September 17, 2024 21:17
tracyboehrer pushed a commit that referenced this pull request Sep 19, 2024
* disable adaptive sampling

* using Microsoft.ApplicationInsights.AspNetCore.Extensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants