Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6841] SkillDialog.InterceptOAuthCardsAsync doesn't support CloudAdapter #6848

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #6841

Description

This PR updates the InterceptOAuthCardsAsync method in SkillDialog to support CloudAdapter in combination with expect replies delivery mode.

Specific Changes

  • In InterceptOAuthCardsAsync added a call to UserTokenAccess.ExchangeTokenAsync method, which handles both adapters.

Testing

This image shows the token exchanged for SSO using CloudAdapter and expect replies.
image

@ceciliaavila ceciliaavila added the Automation: Parity with js The PR needs to be ported to JS label Sep 10, 2024
@ceciliaavila ceciliaavila requested a review from a team as a code owner September 10, 2024 13:15
@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: Parity with js The PR needs to be ported to JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SkillDialog.InterceptOAuthCardsAsync doesn't support CloudAdapter
3 participants