Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CertificateServiceClientCredentialsFactory handles public, Gov, and private clouds #6806

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

tracyboehrer
Copy link
Member

@tracyboehrer tracyboehrer commented Jun 20, 2024

Fixes #6805

This change also handles certificate auth against private clouds as the PasswordServiceClientCredentialFactory does.

@tracyboehrer tracyboehrer requested a review from a team as a code owner June 20, 2024 15:58
@tracyboehrer tracyboehrer added Automation: Parity with python The PR needs to be ported to Python Automation: Parity with js The PR needs to be ported to JS labels Jun 20, 2024
@tracyboehrer tracyboehrer changed the title Added CertificateGovernmentAppCredentials CertificateServiceClientCredentialsFactory handles public, Gov, and private clouds Jun 21, 2024
@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll

@tracyboehrer tracyboehrer merged commit 074b7db into main Jun 24, 2024
12 checks passed
@tracyboehrer tracyboehrer deleted the tracyboehrer/govcert branch June 24, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: Parity with js The PR needs to be ported to JS Automation: Parity with python The PR needs to be ported to Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gov version of CertificateAppCredentials
3 participants