Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Identity.Client bump #6779

Merged
merged 2 commits into from
May 3, 2024
Merged

Conversation

tracyboehrer
Copy link
Member

#minor

@tracyboehrer tracyboehrer requested a review from a team as a code owner May 1, 2024 19:13
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 388608

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 74 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.005%) to 78.16%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Connector/Authentication/ManagedIdentityAuthenticator.cs 1 91.89%
/libraries/Microsoft.Bot.Builder/TokenResolver.cs 4 95.69%
/libraries/AdaptiveExpressions/LRUCache.cs 4 87.18%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Templates/ActivityTemplate.cs 5 72.22%
/libraries/Microsoft.Bot.Builder/TranscriptLoggerMiddleware.cs 5 92.0%
/libraries/Microsoft.Bot.Builder/FileTranscriptLogger.cs 7 94.24%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/AdaptiveDialog.cs 48 88.79%
Totals Coverage Status
Change from base Build 388195: -0.005%
Covered Lines: 26185
Relevant Lines: 33502

💛 - Coveralls

@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll

@tracyboehrer tracyboehrer added the Automation: No parity PR does not need to be applied to other languages. label May 2, 2024
@tracyboehrer
Copy link
Member Author

@sw-joelmut Most of the changes can be ignored. The newer package introduced some ambiguity because "Activity" was defined.

The real change is in ManagedIdentityAuthenticator.cs and corresponding tests. It would appear that the new Managed Identity client automatically retries for exceptions, and everything is now an exception. I didn't see a way to disable their retry. So effectively, this could would be trying max 20 times.

@tracyboehrer tracyboehrer merged commit 91d6a28 into main May 3, 2024
13 of 14 checks passed
@tracyboehrer tracyboehrer deleted the tracyboehrer/identity-bump branch May 3, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants