Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup streaming high-perf logs #6650

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Conversation

stevengum
Copy link
Member

Fixes #6649

Specific Changes

  • Fixes the high performance logging in the StreamingTransportClient from using the wrong EventId.Name
    • Specifically _clientCompleted and _clientKeepAliveSucceed
  • Adds NamedPipeConnectionStarted and NamedPipeConnectionCompleted for use in CloudAdapter.ConnectNamedPipeAsync() instead of using the incorrect WebSocketConnectionStarted and WebSocketConnectionCompleted.
  • Minor cleanup in logs for StreamingSession and TransportHandler

@stevengum stevengum requested a review from a team as a code owner June 21, 2023 19:01
@stevengum stevengum added the Automation: No parity PR does not need to be applied to other languages. label Jun 21, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 356724

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 78.979%

Files with Coverage Reduction New Missed Lines %
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/CloudAdapter.cs 1 77.14%
Totals Coverage Status
Change from base Build 355145: 0.01%
Covered Lines: 25936
Relevant Lines: 32839

💛 - Coveralls

@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll

@tracyboehrer tracyboehrer merged commit 377ea52 into main Jun 22, 2023
@tracyboehrer tracyboehrer deleted the stgum/StreamingLogs branch June 22, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Streaming] High performance logs are incorrect or missing
4 participants