[#6531] Prompt validation of confirm prompt in chatbot is not working for newly added language #6554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceciliaavila
added
the
Automation: Parity with js
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll |
tracyboehrer
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6531
Description
This PR adds the new RecognizeLanguage property in the PromptOptions class to be used in the onRecognizedAsync method allowing a different language than the one determined by the activity.
It also updates the onRecognizedAsync method of the ConfirmPrompt class to use this property solving the issue when a ConfirmPrompt is used along with a TranslationMiddleware.
Specific Changes
Testing
These images show a bot using the translator service and the confirm prompt working as expected.
