Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6512] CodeQL alert SM00431: Information exposure through an exception #6544

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #6512

Description

This PR fixes the CodeQL SM00431 alert related to exposing an exception to the end user (more information).

Specific Changes

  • Updates response SetBody parameter usage, changing from the whole exception to just the message.

Testing

The following image shows the before and after the applied fix, using the CodeQL query tool.
imagen

@sw-joelmut sw-joelmut requested a review from a team as a code owner November 9, 2022 13:06
@tracyboehrer tracyboehrer added the Automation: No parity PR does not need to be applied to other languages. label Nov 10, 2022
@tracyboehrer
Copy link
Member

This is approved, but can't be merged until we correct a compliance issue. This is why the build is failing.

@tracyboehrer tracyboehrer merged commit 746c02f into main Nov 11, 2022
@tracyboehrer tracyboehrer deleted the southworks/fix/setbody-exception branch November 11, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
2 participants