[#6306] NamedPipe could not reconnect correctly when disconnected unexpectedly #6416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceciliaavila
added
the
Automation: No parity
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll |
msomanathan
reviewed
Jul 13, 2022
libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/CloudAdapter.cs
Outdated
Show resolved
Hide resolved
msomanathan
reviewed
Jul 13, 2022
libraries/Microsoft.Bot.Connector.Streaming/Transport/StreamingTransport.cs
Outdated
Show resolved
Hide resolved
msomanathan
suggested changes
Jul 13, 2022
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll |
msomanathan
reviewed
Jul 14, 2022
libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/CloudAdapter.cs
Outdated
Show resolved
Hide resolved
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll |
msomanathan
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6306
Description
This PR adds a loop in the CloudAdapter's ConnectNamedPipeAsync method to keep the connection alive in case of failures
Specific Changes
ConnectNamedPipeAsyncmethod adding a loop while _streamingConnections property is empty.Testing
Here we have two Webchat clients connecting with an echo bot through DL-ASE.
The second client is able to connect with the server after it failed on the first client and reconnected.