Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lowered AppInsights requirements #6412

Merged
merged 4 commits into from
Jul 12, 2022
Merged

Lowered AppInsights requirements #6412

merged 4 commits into from
Jul 12, 2022

Conversation

gabog
Copy link
Contributor

@gabog gabog commented Jul 11, 2022 •
edited
Loading

Fixes #minor

Update App Insights dependencies and net core dependencies to safe versions to be compatible with PVA

@gabog gabog added the Automation: No parity PR does not need to be applied to other languages. label Jul 11, 2022
@coveralls
Copy link
Collaborator

coveralls commented Jul 11, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 311874

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.009%) to 79.057%
Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 90.91%
Totals Coverage Status
Change from base Build 311860: 0.009%
Covered Lines: 25549
Relevant Lines: 32317
💛 - Coveralls

@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll

@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll

@gabog gabog marked this pull request as ready for review July 11, 2022 23:05
@gabog gabog requested a review from a team as a code owner July 11, 2022 23:05
EricDahlvang
EricDahlvang approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@EricDahlvang EricDahlvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 🚀

@gabog gabog merged commit 6504233 into main Jul 12, 2022
@gabog gabog deleted the gabog/AppInsightsPVA branch July 12, 2022 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricDahlvang EricDahlvang EricDahlvang approved these changes

Assignees
No one assigned
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabog @coveralls @BruceHaley @EricDahlvang