Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#6392] Bump Newtonsoft.Json from 12.0.3 to 13.0.1 - Set MaxDepth property (4/4) #6400

Merged
merged 1 commit into from
Jul 5, 2022
Merged

[#6392] Bump Newtonsoft.Json from 12.0.3 to 13.0.1 - Set MaxDepth property (4/4) #6400

merged 1 commit into from
Jul 5, 2022

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #6392

Description

This PR adds the setting of the MaxDepth property in all the JSON Serialize/Deserialize operations.

Specific Changes

  • Set MaxDepth = null in JsonConvert.SerializeObject, JsonConvert.DeserializeObject, and JsonTextReader instances in the generators/Core bot templates.

Testing

This image shows the CoreBot working as expected after the changes:
image

@ceciliaavila ceciliaavila added the Automation: No parity PR does not need to be applied to other languages. label Jul 1, 2022
@ceciliaavila ceciliaavila requested a review from a team as a code owner July 1, 2022 16:53
@tracyboehrer tracyboehrer merged commit 2babf70 into main Jul 5, 2022
@tracyboehrer tracyboehrer deleted the southworks/update/set-maxdepth-null-4 branch July 5, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump Newtonsoft.Json from 12.0.3 to 13.0.1
2 participants
@ceciliaavila @tracyboehrer