Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5837] Fix sentiment values not being set for None / Unknown intent #6348

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #5837

Description

This PR adds the properties object into the RecognizerResult instances in the CrossTrainedRecognizerSet and Recognizer classes, and also adds unit tests to corroborate the properties object is being set correctly.

Specific Changes

  • Adds the Properties attribute value into multiple RecognizerResult instances from the CrossTrainedRecognizerSet and Recognizer classes.
  • Adds unit tests for multiple cases to corroborate the Properties attribute is being set correctly.

Testing

The following images show the new unit tests passing and the bot responding with the included properties in the trace activity.
image
image

@sw-joelmut sw-joelmut added the Automation: Parity with js The PR needs to be ported to JS label May 31, 2022
@sw-joelmut sw-joelmut requested a review from a team as a code owner May 31, 2022 13:11
@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 306789

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.001%) to 78.947%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Recognizers/CrossTrainedRecognizerSet.cs 1 95.77%
/libraries/Microsoft.Bot.Builder.Dialogs/Recognizer.cs 12 66.67%
Totals Coverage Status
Change from base Build 305828: 0.001%
Covered Lines: 25379
Relevant Lines: 32147

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: Parity with js The PR needs to be ported to JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentiment values not being set for None / Unknown intent
4 participants