Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle DialogEvents.RepromptDialog in ForEachElement #6325

Merged
merged 1 commit into from
May 10, 2022
Merged

Handle DialogEvents.RepromptDialog in ForEachElement #6325

merged 1 commit into from
May 10, 2022

Conversation

EricDahlvang
Copy link
Member

Fixes #6313

This PR adds support to ForEachElement to properly handle RepromptDialog event after an interruption.

@EricDahlvang EricDahlvang requested a review from a team as a code owner May 9, 2022 19:10
@EricDahlvang EricDahlvang added the Automation: No parity PR does not need to be applied to other languages. label May 9, 2022
@EricDahlvang EricDahlvang mentioned this pull request May 9, 2022
Closed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 303690

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 78.948%
Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 93.94%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/ForEachElement.cs 8 90.0%
Totals Coverage Status
Change from base Build 303081: 0.2%
Covered Lines: 25374
Relevant Lines: 32140
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit e21c96a into main May 10, 2022
@tracyboehrer tracyboehrer deleted the eric/forEachElementReprompt branch May 10, 2022 17:09
EricDahlvang added a commit that referenced this pull request May 10, 2022
@EricDahlvang
Handle DialogEvents.RepromptDialog in ForEachElement (#6325)
38cada5
tracyboehrer pushed a commit that referenced this pull request May 10, 2022
@EricDahlvang
Handle DialogEvents.RepromptDialog in ForEachElement (#6325) (#6327)
4a9129b
@LeeParrishMSFT LeeParrishMSFT mentioned this pull request Aug 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosscastro carlosscastro carlosscastro approved these changes

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ForeachElement Does not Re-prompt
4 participants
@EricDahlvang @coveralls @tracyboehrer @carlosscastro