Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#5678] Channels "enumeration" is out of date #6314

Merged
merged 1 commit into from
May 17, 2022
Merged

[#5678] Channels "enumeration" is out of date #6314

merged 1 commit into from
May 17, 2022

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #5678

Description

This PR updates the Channels enum adding Outlook and marking Twilio as obsolete.

Specific Changes

  • Added new channel Outlook.
  • Marked Twilio as obsolete.

Testing

This image shows the tests passing after the changes.
image

@ceciliaavila ceciliaavila added the Automation: No parity PR does not need to be applied to other languages. label Apr 29, 2022
@ceciliaavila ceciliaavila requested a review from a team as a code owner April 29, 2022 20:27
@coveralls
Copy link
Collaborator

coveralls commented Apr 29, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 304878

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 78.945%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/ForEachElement.cs 8 90.0%
/libraries/Microsoft.Bot.Builder/BotFrameworkAdapter.cs 17 47.91%
Totals Coverage Status
Change from base Build 302179: 0.2%
Covered Lines: 25373
Relevant Lines: 32140
💛 - Coveralls

@tracyboehrer tracyboehrer reopened this May 17, 2022
@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll

@tracyboehrer tracyboehrer merged commit 6cd478d into main May 17, 2022
@tracyboehrer tracyboehrer deleted the southworks/update/channels-enum branch May 17, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabog gabog gabog approved these changes

Assignees
No one assigned
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Channels "enumeration" is out of date
5 participants
@ceciliaavila @coveralls @BruceHaley @gabog @tracyboehrer