Created XML tags using System.Xml #6312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
breakingram
changed the title
breakingram
added
the
Automation: No parity
EricDahlvang
suggested changes
Jun 13, 2022
EricDahlvang
added
Automation: Parity with js
breakingram
force-pushed
the
ramfattah/SetSpeakMiddleware
branch
from
b52e08f to
a7a4cf0
Compare
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll |
* Changes raw string to XDocument to create xml * Parsed string xml in speak tag * remove unnecessary imports * Updated unit test & code refactor * Multiple voice tags can be added in speak field * function name update * Check for valid XML tags to reduce processing * Add unit tests for SetSpeakMiddleware
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5792
Description
Ensure the appropriate SSML tags are set on the Activity Speak property using System.Xml.Linq classes
such as XDocument & XElement.
Testing
Voice is added to Speak property
AddVoice
Input:
Output:
Custom voice tag
AddVoice_NullSpeak
Voice is added with no speak tag
Input:
Output:
Multiple voice tags
AddMultiVoice
Input:
Output:
Custom speak is added with voice tag
AddSpeakWithVoice
Input:
Output:
Custom speak is added with no voice tag
AddSpeak_NullVoice
Input:
Output:
All SetSpeakMiddlewareTest
SetSpeakMiddlewareTests.cs