Fixing Issue#3568, bot receives a utterances smaller than the entity indexes

[arielcintra]

Fixes #

Description

I've got the same issue as described on https://github.com/microsoft/botframework-solutions/issues/3568 and as analyzing the bot framework code and my LUIS applications, my team could get to the result that the code is trying to peform a substring on a utterance with bigger entities indexes.

Specific Changes

The change performed was to verirfy if the utterance length is smaller or equals to the entity size (endIndex - startIndex) and, as a suggestion, return the utterance, if not continues to perform the substring as always.
I putted as suggestion so you guys analyze if it does not impact other parts of the framework. None of the unit test were broken with the change.

Testing

[ghost]

All CLA requirements met.

[chrimc62]

[tomlm]

🕐

[tomlm]

[tdurnford]

@arielcintra Can you make a no-op change to the PR so it reruns the checks? Not sure why we're not able to rerun them on our end.

[EricDahlvang]

@tdurnford they can be re-run from the Azure devops Pipeline, using the commit hash. They are running now.

[EricDahlvang]

Oh, sorry ... that did not work. Presumably because this PR is from a fork?

[tdurnford]

@arielcintra It looks like your branch is based on master instead of main. Can you please rebase your PR to the main branch?

Thanks @BruceHaley for investigating!

[mrivera-ms]

@arielcintra , could you please look at the message above to resolve the failing checks? Thank you.

[cleemullins]

Close this PR out:

1. It's a code change w/o Unit Tests.
2. It's been inactive / unresponded for quite some time.

@arielcintra This looks like a great fix, and we would like to take it. Please update / re-open the PR with a Unit Test and address the merge issue so we can take it.