Skip BA2021 Analysis on .NET R2R & NativeAOT PE on non-Windows Platforms #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change skips analysis when it finds non-Windows .NET R2R & NativeAOT PE's. The reason for this is the DoNotMarkWritableSectionsAsExecutable is Windows specific and R2R/NativeAOT do not follow Windows layout rules on non-Windows platforms. Fixes microsoft#970
|
@michaelcfanning @marmegh when either of you have a moment, can you please review? |
AllDwarf
requested review from
AllDwarf and
a team
and removed request for
marmegh
|
Basically once there will be tests it's good to go. What would be nice to have some files for testing it locally, can you provide them please? @steveisok cc @mkacmar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change skips analysis when it finds non-Windows .NET R2R & NativeAOT PE's. The reason for this is the
DoNotMarkWritableSectionsAsExecutableis Windows specific and R2R/NativeAOT do not follow Windows layout rules on non-Windows platforms.Fixes #970