This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
support BYO resource groups and don't delete them on destroy #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #474 ... It adds the ability for using your own resource group in deployments. Additionally, resource group creation has been moved specifically to the environments rather than within modules themselves. Modules reference the resource_group as a data item rather than a resource. This way, the creation or reference of an existing resource group is isolated to the environments.
Documentation updates are required for this (in progress).
The reason for not using the TF
prevent_destroyflag is discussed in #474 -- specifically, the RG could still be destroyed based on the following: hashicorp/terraform#17599I'll post a comment when the documentation is updated.